Draft: Add secondary action buttons as allowed child roles - #1498
Closed
smhigley wants to merge 3 commits into
Closed
Draft: Add secondary action buttons as allowed child roles#1498smhigley wants to merge 3 commits into
smhigley wants to merge 3 commits into
Conversation
smhigley
marked this pull request as draft
June 3, 2021 10:56
Contributor
|
I don't understand the concept yet: the button should be on the same level in the DOM as option (as a child of listbox)? I assumed so far that the buttons should be child elements of option and the listbox contains only options.
|
Contributor
Author
|
Test page for support of nested vs. sibling action buttons is here: https://a11y-screenreader-demos.netlify.app/studies/secondary-actions/ (updated w/ actual link, because I fail at copy/paste 😅) |
Contributor
Author
|
Closing in favor of aria-actions (#1805) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1440
This is a proof of concept for allowing secondary actions in composite widget roles, and relies on the changes in #1454.
The relevant changes in this PR are these additional terms:
And this addition to the allowed child roles of
listbox, as an example:<li><rref>button</rref> if <a>controlling</a> a child <rref>option</rref></li>Preview | Diff