Add Golf Data support#307
Open
benhalpern wants to merge 1 commit into
Open
Conversation
Author
|
Since some fitness users might not care about golf, maybe a way to flag this on and off could make sense as well? I think in general it makes sense to have this more or less on par with the other features like in this PR because golf is pretty first-class in the Garmin ecosystem, but project expectations might put this more as an "optional" thing? |
Owner
|
Please re-target the PR against the develop branch. |
Owner
|
Ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I love the project, it's working great!
I have added golf data, as it is native to the Garmin Connect experience, and it was the source I was most interested in. As golf is core to the Garmin ecosystem, I'm sure that's the case for many others.
I attempted to follow existing patterns, but let me know if anything needs to be changed (or otherwise I welcome any changes by @tcgoetz.
Thanks a lot.