Materials Update from reliable source#424
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Smoke tested in editor and in engine. nothing seems to break so it's a strict upgrade. haven't spent a lot of time on deep verification but since everything is "fine" that can be done later.
no idea where git got the other 7 random commits to add to the PR. all you want is 6938aa3 AFAIK cause I pulled dev, removed any changes, applied patch, tested, committed and pushed to my remote. no idea how my remote was out of sync but I don't wanna fight github rn. I'll do a hard reset once I know we've got the content in SML, which I guess someone else could do themselves instead of taking this PR as thanks to the quality of the file integration was painless.