Fix #327 - Update dependencies, enforce Node>=4.0, and default to Electron 1.6.6#341
Conversation
|
EDIT see message below, I did my breaking-change hunting homework in our deps, everything seems okay :) So, @jiahaog @darrenhaken and (as you showed interest in #327) @ambonium @maxdec @danimalweb: could you try this branch?
Thanks everyone! Issues I noticed so far:
|
275f5be to
4b2882d
Compare
|
@jiahaog @darrenhaken update compatibility checking homework done. I think everything is 💚 green, and adjusted a few minor knobs. If anything, the
|
|
@ronjouch Thanks, really awesome job! Let me do some testing on my side, and go through the changes with electron packager |
52adf72 to
51587ea
Compare
|
Status for smoke tests:
|
aa4de02 to
9cb1fd5
Compare
|
The tests pass for me on macOS (10.12.4) with Node 7.9.0 |
|
Works fine on my mac @ronjouch, thanks alot! |
|
Alright let's merge this and cut a release soon! |
Do NOT merge this PR right now, it deserves some time of cross-OS testing.