Skip to content
This repository was archived by the owner on Sep 29, 2023. It is now read-only.

Fix #327 - Update dependencies, enforce Node>=4.0, and default to Electron 1.6.6#341

Merged
ronjouch merged 1 commit into
developmentfrom
deps
Apr 18, 2017
Merged

Fix #327 - Update dependencies, enforce Node>=4.0, and default to Electron 1.6.6#341
ronjouch merged 1 commit into
developmentfrom
deps

Conversation

@ronjouch

@ronjouch ronjouch commented Apr 10, 2017

Copy link
Copy Markdown
Contributor

Do NOT merge this PR right now, it deserves some time of cross-OS testing.

@ronjouch

ronjouch commented Apr 10, 2017

Copy link
Copy Markdown
Contributor Author

EDIT see message below, I did my breaking-change hunting homework in our deps, everything seems okay :) Aaaalright, that being said: this is the fastest, laziest, YOLOest, shoot-from-the-hip-est npm mass-update ever, I didn't even read release notes for major versions of new deps. That being said, IT WORKS FOR ME \o/ under Linux, so I figured I'd do the homework later and would start by getting feedback from interested people 😃.

So, @jiahaog @darrenhaken and (as you showed interest in #327) @ambonium @maxdec @danimalweb: could you try this branch?

  1. Follow our developer documentation.
  2. Checkout the PR: git fetch --all && git checkout deps
  3. Then, all feedback welcome about npm test and, of course, re-nativefying your apps and running for a few days with them :) . Please indicate your OS/Node for all positive/negative feedback.

Thanks everyone!


Issues I noticed so far:

  • EDIT fixed in updated commit, I had broken this when changing options version to electronVersion. Useragent detection from Electron is broken: my Gmail app bundled with a fresh Electron 1.6.6 (bundling Chrome 56) complains that "This version of Chrome is no longer supported", which is justified as navigator.userAgent reports
    Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/47.0.2526.73 Safari/537.36.

@ronjouch ronjouch force-pushed the deps branch 3 times, most recently from 275f5be to 4b2882d Compare April 11, 2017 01:11
@ronjouch

ronjouch commented Apr 11, 2017

Copy link
Copy Markdown
Contributor Author

@jiahaog @darrenhaken update compatibility checking homework done. I think everything is 💚 green, and adjusted a few minor knobs. If anything, the electron-packager changes (linked below) deserve a look, only to know about new features we might be interested in. I pushed an updated commit, tests welcome :) (especially windows and OSX, which I couldn't test yet), and here are my deps update notes with link to each project changelog:

  • App
    • electron-window-state 3.0.3 → 4.1.0
      • Nothing: single breaking change happened in 4.0.0, which "drops support for electron versions < 1.0.0") and nativefier already ships 1.1.3.
  • Deps
    • async 1.5.2 → 2.3.0
      • Usage: async.waterfall in src/build/buildMain.js, src/options/optionsMain.js, and async.eachSeries in test/module/index-spec.js.
      • Only change I see about those was in 2.0.0 for Waterfall multiple callback defense, but I don't see such usage in our code.
    • axios 0.11.1 → 0.16.1
      • Usage: .get in src/infer/inferUserAgent.js and src/helpers/helpers.js, not impacted by breaking changes.
    • cheerio 0.20.0 → 0.22.0
      • Usage: .load in src/infer/inferTitle.js, not impacted.
    • electron-packager 7.0.1 → 8.6.0
      • Usage: .packager() in src/build/buildMain.js, with options passed from src/options/optionsMain.js.
      • 7.6.0 enforced minimum Node version, which we should too; updated our package.json with ">= 4.0".
      • 8.5.0 renamed option version into electronVersion; updated our options factory.
    • progress 1.1.8 → 2.0.0
      • Usage: ProgressBar in src/helpers/dishonestProgress.js, nada.
    • tmp 0.0.28 → 0.0.31
      • Usage: .setGracefulCleanup, .dirSync, all clear.
    • validator 5.2.0 → 7.0.0
      • Usage: .isURL in src/options/normalizeUrl.js, nada.
  • devDeps
    • gulp-istanbul 0.10.3 → 1.1.1, gulp-mocha 2.2.0 → 4.3.0, gulp-sourcemaps 1.6.0 → 2.5.1
      • Eh, if something's broken, tests will fail ¯\_(ツ)_/¯.
    • gulp-sourcemaps 2.5.0 → 2.6.0
      • Usage: .init(), .write() in gulp/helpers/gulp-helpers.js, unaffected by deprecated options.

@ronjouch ronjouch changed the title Update dependencies and default to Electron 1.6.6 Update dependencies, enforce Node>=4.0, and default to Electron 1.6.6 Apr 11, 2017
@jiahaog

jiahaog commented Apr 11, 2017

Copy link
Copy Markdown
Member

@ronjouch Thanks, really awesome job! Let me do some testing on my side, and go through the changes with electron packager

@ronjouch ronjouch force-pushed the deps branch 2 times, most recently from 52adf72 to 51587ea Compare April 16, 2017 16:32
@ronjouch ronjouch changed the title Update dependencies, enforce Node>=4.0, and default to Electron 1.6.6 Fix #327 - Update dependencies, enforce Node>=4.0, and default to Electron 1.6.6 Apr 16, 2017
@ronjouch

ronjouch commented Apr 16, 2017

Copy link
Copy Markdown
Contributor Author

Status for smoke tests:

  • 💚 for Arch and Ubuntu Linux on Node 7.
  • 💚 for Windows10 on Node 6 LTS.
  • ❓ for macOS, @darrenhaken / @jiahaog on it.

@ronjouch ronjouch force-pushed the deps branch 3 times, most recently from aa4de02 to 9cb1fd5 Compare April 18, 2017 01:03
@maxdec

maxdec commented Apr 18, 2017

Copy link
Copy Markdown

The tests pass for me on macOS (10.12.4) with Node 7.9.0
I'll try to migrate Messenger and Plex and see if I notice anything.

@jiahaog

jiahaog commented Apr 18, 2017

Copy link
Copy Markdown
Member

Works fine on my mac @ronjouch, thanks alot!

@ronjouch

Copy link
Copy Markdown
Contributor Author

Alright let's merge this and cut a release soon!

@ronjouch ronjouch merged commit be4b9a7 into development Apr 18, 2017
@ronjouch ronjouch deleted the deps branch April 18, 2017 23:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants