Skip to content

Add setting to control whether to focus the inline editor in peek widget by default#88185

Merged
jrieken merged 1 commit into
microsoft:masterfrom
jeanp413:peek-widget-focus-setting
Jan 13, 2020
Merged

Add setting to control whether to focus the inline editor in peek widget by default#88185
jrieken merged 1 commit into
microsoft:masterfrom
jeanp413:peek-widget-focus-setting

Conversation

@jeanp413

@jeanp413 jeanp413 commented Jan 7, 2020

Copy link
Copy Markdown
Contributor

This PR fixes #23001

@jeanp413 jeanp413 force-pushed the peek-widget-focus-setting branch from 766e181 to a78e583 Compare January 7, 2020 03:10
@jrieken jrieken self-assigned this Jan 7, 2020
@jrieken jrieken added this to the January 2020 milestone Jan 7, 2020
Comment thread src/vs/editor/common/config/commonEditorConfig.ts Outdated
Comment thread src/vs/editor/contrib/gotoSymbol/peek/referencesController.ts Outdated
Comment thread src/vs/editor/contrib/gotoSymbol/peek/referencesController.ts
Comment thread src/vs/editor/contrib/gotoSymbol/peek/referencesController.ts Outdated
@jeanp413 jeanp413 force-pushed the peek-widget-focus-setting branch from a78e583 to ca5375d Compare January 7, 2020 12:05
@jeanp413 jeanp413 force-pushed the peek-widget-focus-setting branch from ca5375d to d6a3ca7 Compare January 9, 2020 02:46

@jrieken jrieken left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Not super happy with the name of the setting yet, but we can tweak that at a later time - unless you have spontaneous idea.

@jrieken jrieken merged commit 0b134f8 into microsoft:master Jan 13, 2020
@jeanp413 jeanp413 deleted the peek-widget-focus-setting branch January 13, 2020 09:58
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Focus peek window on creation

2 participants