AH: use plan widget instead of questions carousel when exiting plan mode#322495
Open
justschen wants to merge 3 commits into
Open
AH: use plan widget instead of questions carousel when exiting plan mode#322495justschen wants to merge 3 commits into
justschen wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Agent Host “exit plan mode” flow to use the existing chat plan review widget (instead of the questions carousel), enabling users to inspect the plan (and optionally open the full plan file) before continuing with implementation.
Changes:
- Introduces an optional
planReviewpayload onChatInputRequest(via a typed extension) and emits it from the Copilot agent session forexitPlanMode.request. - Updates the workbench Agent Host session handler to render
ChatPlanReviewDatafor plan-review input requests, and adds coverage for dispatch/clearing behavior. - Adjusts plan review widget styling (borders/focus styling/background behavior) and updates associated tests.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/test/browser/agentSessions/agentHostChatContribution.test.ts | Adds browser-side tests ensuring plan-review requests render the plan widget (not the carousel), dispatch completion correctly, and clear docked UI on remote completion. |
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/media/chatPlanReview.css | Updates plan review widget border/background/focus styling and adapts surface background for agents window/editor contexts. |
| src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostSessionHandler.ts | Adds plan-review input request handling to produce ChatPlanReviewData, translate completions to protocol answers, and clear the input’s docked plan review widget. |
| src/vs/platform/agentHost/test/node/copilotAgentSession.test.ts | Updates plan-mode tests to validate the new plan-review payload and ensures no separate markdown “plan summary” part is emitted. |
| src/vs/platform/agentHost/node/copilot/copilotAgentSession.ts | Changes exitPlanMode.request to emit a plan-review input request (with actions + optional plan URI) rather than a markdown+question carousel flow. |
| src/vs/platform/agentHost/common/agentHostPlanReview.ts | Adds shared types for the plan-review payload attached to chat input requests. |
Copilot's findings
- Files reviewed: 6/6 changed files
- Comments generated: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uses plan mode widget that let's users inspect plan before letting it continue with implementation.
