Fix auto mode fallback for empty model providers#316174
Merged
Merged
Conversation
Treat an empty current model provider as no provider affinity so Auto Mode still falls back to the first available model with a known endpoint. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Auto Mode’s default model selection when the previously selected endpoint has an empty modelProvider, ensuring that an empty provider is treated as “no provider affinity” (so selection correctly falls back to the first available model instead of mistakenly short-circuiting).
Changes:
- Fix
_selectDefaultModelto avoid&&producing an empty-string value that blocks the??fallback. - Add a regression test ensuring an empty-provider model remains selectable across subsequent turns.
Show a summary per file
| File | Description |
|---|---|
| extensions/copilot/src/platform/endpoint/node/automodeService.ts | Fix default model selection to treat empty currentModelProvider as no affinity so the first available model is chosen correctly. |
| extensions/copilot/src/platform/endpoint/node/test/automodeService.spec.ts | Add a regression test covering repeated turns when the current endpoint’s modelProvider is empty. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
bhavyaus
approved these changes
May 13, 2026
dmitrivMS
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
PATH="$PWD/node_modules/.bin:$PATH" npm --prefix extensions/copilot run typecheckPATH="$PWD/node_modules/.bin:$PATH" npm --prefix extensions/copilot run test:unit -- src/platform/endpoint/node/test/automodeService.spec.tsnode --experimental-strip-types build/hygiene.ts extensions/copilot/src/platform/endpoint/node/automodeService.ts extensions/copilot/src/platform/endpoint/node/test/automodeService.spec.tsnpm run precommit