fix: memory leak in pane composite bar#282589
Merged
dmitrivMS merged 10 commits intoJun 4, 2026
Merged
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a disposable leak in the workbench PaneCompositeBar by ensuring per-composite actions are properly lifecycle-managed when composites are hidden/removed and later re-created.
Changes:
- Replace the
compositeActionscache from a plainMapto a_register’dDisposableMapso cached action bundles are disposed when replaced/removed. - Stop
_register’ing individual composite actions into the long-livedPaneCompositeBarstore; instead dispose them via the map entry’sdispose(). - Ensure all three actions (
activityAction,pinnedAction, andbadgeAction) are disposed when a composite is hidden/removed.
You can also share your feedback on Copilot code review. Take the survey.
Contributor
There was a problem hiding this comment.
Copilot's findings
Comments suppressed due to low confidence (1)
src/vs/workbench/browser/parts/paneCompositeBar.ts:335
- In the placeholder branch,
toCompositeBarActionItem(...)is computed inline while constructing the activity action. Ifoptions.iconis enabled and the icon is a URI, this can also insert CSS rules; keeping it in a localactionItemavoids accidental repeated computation if this block is refactored/extended and keeps the pattern consistent with the non-placeholder branch.
}
const disposable = combinedDisposable(activityAction, pinnedAction, badgeAction);
compositeActions = { activityAction, pinnedAction, badgeAction, dispose: () => disposable.dispose() };
this.compositeActions.set(compositeId, compositeActions);
}
return compositeActions;
}
- Files reviewed: 1/1 changed files
- Comments generated: 1
Contributor
|
@SimonSiefke Thank you! |
dmitrivMS
approved these changes
May 31, 2026
benibenj
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a memory leak in
paneCompositeBar.It seems the
paneCompositeBarcan be visible for a longer period of time, while it's actions can update many times.By changing the code to use a
DisposableMap, it ensures that the previous actions are disposed when the actions are updated.Before
When renaming a variable 97 times with refactor preview, it seems 3 actions are created each time:
After
When renaming a variable 97 times with refactor preview, no more action leaks are detected: