Add Vitest test suite for pure-logic modules - #1927
Open
sweenzor wants to merge 2 commits into
Open
Conversation
sweenzor
commented
Mar 20, 2026
| @@ -0,0 +1,99 @@ | |||
| /* | |||
| * Copyright 2010-2020 Gildas Lormeau | |||
Author
There was a problem hiding this comment.
Suggested change
| * Copyright 2010-2020 Gildas Lormeau | |
| * Copyright 2010-2026 Gildas Lormeau |
Test srcset parser, MHTML utilities, yabson serialization round-trips, and config/download helpers. Extract pure functions from config.js and downloads.js into config-utils.js to make them importable without browser API dependencies. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Remove unused MIGRATION_DEFAULT_VARIABLES_VALUES import in config.js (only updateFilenameTemplate needs it, and it lives in config-utils.js) - Declare TextEncoder/atob globals in mhtml-util.test.js so the test file passes eslint - Add @eslint/js to devDependencies: eslint.config.mjs imports it, but eslint 10 no longer ships it as a transitive dependency, so "npx eslint ." fails on a fresh checkout - Add tests for decodeBinary and decodeBase64 (base64 encoding of the full byte range, chunk-boundary-sized input, charset handling) - Collapse leftover double blank lines where functions were extracted Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
sweenzor
marked this pull request as ready for review
July 11, 2026 17:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some ideas about how a test suite for SingleFile might look. Let me know your thoughts @gildas-lormeau!
Summary
decodeBinary/decodeBase64), yabson serialization round-trips, and config/download helpers@eslint/jsto devDependencies: eslint.config.mjs imports it, but ESLint 10 no longer ships it as a transitive dependency, sonpx eslint .fails on a fresh checkout without itTest plan
preserve-caught-errorhits from ESLint 10's new recommended rule, unrelated to this change)