Add responsive content loader mode#428
Open
landeqiming666 wants to merge 1 commit into
Open
Conversation
Open
Author
|
Hi, just a gentle follow-up on this PR. It is scoped to the linked responsive mode issue, includes the validation notes in the PR description, and is ready for maintainer review. Please let me know if you would prefer any changes to the implementation or tests. Thanks! |
Author
|
Hi maintainers, gentle follow-up on this PR. It remains mergeable, the Socket checks are green, and the change is scoped to the responsive mode behavior from the linked issue. The implementation and validation notes are in the PR description. Please let me know if you would prefer a different API shape, docs wording, or test coverage before review. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
responsiveprop forContentLoaderwidth="100%"andheight="auto"while keeping the drawing ratio fromviewBoxThis is a smaller alternative for #18 than the older conflicting PR #60: it avoids breakpoint parsing, dependency churn, lockfile changes, and keeps the existing fixed-size behavior unchanged by default.
Test plan
npm test -- --runInBandnpm run buildCloses #18
IssueHunt Summary
Referenced issues
This pull request has been submitted to: