Skip to content

add --all flag to install all skills in a repo#13471

Merged
tommaso-moro merged 3 commits into
trunkfrom
tommy/skill-install-all-flag
Jun 1, 2026
Merged

add --all flag to install all skills in a repo#13471
tommaso-moro merged 3 commits into
trunkfrom
tommy/skill-install-all-flag

Conversation

@tommaso-moro

@tommaso-moro tommaso-moro commented May 20, 2026

Copy link
Copy Markdown
Contributor

Fixes #13453

Summary

  • Add --all to gh skill install so users can install every discovered skill from a repository without providing an individual skill name.
  • Reuse the existing all-skills selection path, including collision detection, so skills that would overwrite each other still fail with guidance.
  • Update help text, examples, and tests for flag parsing, validation, and multi-skill remote installs.

Testing

  • go test ./pkg/cmd/skills/install

@tommaso-moro tommaso-moro marked this pull request as ready for review May 22, 2026 14:57
@tommaso-moro tommaso-moro requested review from a team as code owners May 22, 2026 14:57
@tommaso-moro tommaso-moro requested review from babakks and Copilot May 22, 2026 14:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a --all option to gh skill install to install every discovered skill from a repository without specifying an individual skill, reusing the existing “install all skills” selection path (including collision detection), and extends tests to cover flag parsing and remote multi-skill installs.

Changes:

  • Add --all flag handling and validation to gh skill install.
  • Reuse the existing “all skills” selection flow by short-circuiting selection when --all is set.
  • Update help/examples and expand tests for parsing and remote installation of multiple skills.
Show a summary per file
File Description
pkg/cmd/skills/install/install.go Adds --all flag, validation, help text, and selection behavior to install all discovered skills.
pkg/cmd/skills/install/install_test.go Adds parsing coverage for --all and a new test ensuring remote multi-skill install works with --all.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comments suppressed due to low confidence (1)

pkg/cmd/skills/install/install.go:227

  • Flag help for --all says "without prompting", but gh skill install --all may still prompt for agent/scope selection in interactive mode. Consider clarifying that it installs all discovered skills without prompting for which skills to install.
	cmdutil.StringEnumFlag(cmd, &opts.Scope, "scope", "", "project", []string{"project", "user"}, "Installation scope")
	cmd.Flags().StringVar(&opts.Pin, "pin", "", "Pin to a specific git tag or commit SHA")
	cmd.Flags().StringVar(&opts.Dir, "dir", "", "Install to a custom directory (overrides --agent and --scope)")
	cmd.Flags().BoolVar(&opts.All, "all", false, "Install all skills without prompting")
	cmd.Flags().BoolVarP(&opts.Force, "force", "f", false, "Overwrite existing skills without prompting")
  • Files reviewed: 2/2 changed files
  • Comments generated: 2

Comment thread pkg/cmd/skills/install/install.go Outdated
Comment thread pkg/cmd/skills/install/install.go Outdated

@babakks babakks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a question that may (not) need change.

Comment thread pkg/cmd/skills/install/install.go
jvalentinarodriguezlenis-oss

This comment was marked as spam.

@tommaso-moro tommaso-moro merged commit e6fa2fa into trunk Jun 1, 2026
11 checks passed
@tommaso-moro tommaso-moro deleted the tommy/skill-install-all-flag branch June 1, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for --all param for gh skill install

4 participants