Skip to content

[18.0] [MIG] sale_company_currency: Migration to 18.0#3685

Merged
OCA-git-bot merged 19 commits into
OCA:18.0from
bizzappdev:18.0-mig-sale_company_currency-BAD
May 12, 2025
Merged

[18.0] [MIG] sale_company_currency: Migration to 18.0#3685
OCA-git-bot merged 19 commits into
OCA:18.0from
bizzappdev:18.0-mig-sale_company_currency-BAD

Conversation

@bizzappdev

Copy link
Copy Markdown
Contributor

No description provided.

@bizzappdev bizzappdev marked this pull request as ready for review April 21, 2025 14:35

@matteotognini matteotognini left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functional ok

@rousseldenis

Copy link
Copy Markdown
Contributor

/ocabot migration sale_company_currency

@rousseldenis rousseldenis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bizzappdev Thanks for this. Maybe could you extract tests addition in a separate commit in order to be able to backport it ?

@bizzappdev bizzappdev force-pushed the 18.0-mig-sale_company_currency-BAD branch from 566e176 to d13fd20 Compare April 29, 2025 08:57
@bizzappdev

Copy link
Copy Markdown
Contributor Author

@rousseldenis changes are done.

@TDu TDu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, thanks for migrating.

@twalter-c2c twalter-c2c left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you.

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@ivs-cetmix ivs-cetmix left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bizzappdev , thank you for your contribution!
Please squash administrative commits (if any) with the previous commit for reducing commit noise as per the migration checklist requirements.

leemannd and others added 12 commits May 12, 2025 11:32
Currently translated at 83.3% (5 of 6 strings)

Translation: sale-workflow-10.0/sale-workflow-10.0-sale_company_currency
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_company_currency/pt/
Currently translated at 100.0% (6 of 6 strings)

Translation: sale-workflow-10.0/sale-workflow-10.0-sale_company_currency
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_company_currency/ca/
Currently translated at 100.0% (6 of 6 strings)

Translation: sale-workflow-10.0/sale-workflow-10.0-sale_company_currency
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_company_currency/es/
Currently translated at 100.0% (6 of 6 strings)

Translation: sale-workflow-10.0/sale-workflow-10.0-sale_company_currency
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_company_currency/hr/
Currently translated at 33.3% (2 of 6 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_company_currency
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_company_currency/it/
Fixed field name to position by
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_company_currency
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_company_currency/
@bizzappdev bizzappdev force-pushed the 18.0-mig-sale_company_currency-BAD branch from d13fd20 to 8ab7a20 Compare May 12, 2025 06:12
@bizzappdev

Copy link
Copy Markdown
Contributor Author

@ivs-cetmix squashing of the commits is done.

@ivs-cetmix ivs-cetmix left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bizzappdev thank you, LGTM!

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-3685-by-ivs-cetmix-bump-nobump, awaiting test results.

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 2fd656c into OCA:18.0 May 12, 2025
7 checks passed
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at ac2448f. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.