[18.0][MIG] product_price_category by bealdav · Pull Request #3618 · OCA/sale-workflow

bealdav · 2025-03-10T15:36:46Z

No description provided.

bealdav · 2025-05-22T07:27:03Z

Just tested, fix done by @florian-dacosta works nicely

I approve it

florian-dacosta · 2025-05-22T07:50:18Z

FYI as last contributor / reviewers, it may be of your interest
@sbejaoui
@rousseldenis
@marielejeune
@flotho
@JordiMForgeFlow

rousseldenis · 2025-05-22T08:59:30Z

/ocabot migration product_price_category

rousseldenis · 2025-05-22T09:02:49Z

        selection_add=[("2b_product_price_category", "Price Category")],
        ondelete={"2b_product_price_category": "set default"},
    )
+    display_applied_on = fields.Selection(


@bealdav No need of migration script for this ?

Hum, true, it is for a new project, and I did not even think about it...
I'll provide one

Thanks for your vigilance @rousseldenis
I've added a migration script.I could not test it on a real migrated database though, but I did test that it runs without crashing

JordiMForgeFlow · 2025-05-22T11:08:30Z


-    def _compute_name_and_price(self):
-        result = super()._compute_name_and_price()
+    def _compute_name(self):


api.depends should be maintained from the original method

I did the change.
I hardly believed it was not necessary although it does not hurt.

@JordiMForgeFlow For depends(), Odoo will append new dependencies in further modules that decorates same function. That's why you don't need to put original fields in it. @florian-dacosta This is why it worked without. This is not necessary.

I'm wondering if price_category_id should not be in depends ?

I've just rebased this old PR.
@rousseldenis , concerning if price_category_id should trigger this method, on my side I think not.
I've tested here

On save computed name is refreshed when you change the price category

It seems to me we have answered all questions.

A merge can be done ?

Please @rousseldenis are these screens anwser to your questions ?
Could you merge if it's ok ?

@florian-dacosta can you remove the useless depends field added
I confirm that it's useless and also it propagate a wrong believe that you need to add all the depends
The code in V18 here : https://github.com/odoo/odoo/blob/dc9dc90dd99f1f7dfb4a781ad2bec7378548d95b/odoo/fields.py#L585 will aggregate the depends. It's the case since version 13 at least and maybe even before (but I do not remember)

Regarding the fact of add "price_category_id" it's needed. The rule is simple if the result of computation of the field depend on "price_category_id", you have to add it.

Right now the onchange is broken (the name only change when you save it). I am pretty sure that if you do an import (an update) it will not update the name if there is not depends on "price_category_id"

So please add it

Done @sebastienbeau

@rousseldenis we finally found you're right about depends on price_category_id.

[UPD] Update product_price_category.pot [ADD] icon.png

Currently translated at 73.3% (11 of 15 strings) Translation: sale-workflow-10.0/sale-workflow-10.0-product_price_category Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-product_price_category/it/

Currently translated at 100.0% (15 of 15 strings) Translation: sale-workflow-10.0/sale-workflow-10.0-product_price_category Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-product_price_category/ca/

Currently translated at 100.0% (15 of 15 strings) Translation: sale-workflow-10.0/sale-workflow-10.0-product_price_category Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-product_price_category/es/ [UPD] Switch to Github Actions / Copier update

[FIX] - fix ui Co-authored-by: Laurent Mignon (ACSONE) <laurent.mignon@acsone.eu>

Prior to this commit `name` was not correctly computed when `applied_on` value is `2b_product_price_category`.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-product_price_category Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-product_price_category/

…icelist

florian-dacosta

Functional test + new review
All seems good, thanks @bealdav

sebastienbeau

LGTM (code review)

sebastienbeau · 2026-01-22T11:23:08Z


-    def _compute_name_and_price(self):
-        result = super()._compute_name_and_price()
+    def _compute_name(self):


OCA-git-bot · 2026-01-22T11:24:10Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-3618-by-sebastienbeau-bump-patch, awaiting test results.

Signed-off-by sebastienbeau

sebastienbeau · 2026-01-22T11:24:58Z

/ocabot merge nobump

OCA-git-bot · 2026-01-22T11:25:06Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-3618-by-sebastienbeau-bump-nobump, awaiting test results.

OCA-git-bot · 2026-01-22T11:25:18Z

@sebastienbeau your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-3618-by-sebastienbeau-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

OCA-git-bot · 2026-01-22T11:28:04Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot · 2026-01-22T11:45:32Z

Congratulations, your PR was merged at 5155df7. Thanks a lot for contributing to OCA. ❤️

bealdav force-pushed the 18.0-mig-product_price_category branch from e9feec7 to e86a5ed Compare March 10, 2025 15:58

bealdav marked this pull request as draft March 11, 2025 14:33

bealdav closed this Apr 10, 2025

bealdav reopened this May 21, 2025

florian-dacosta force-pushed the 18.0-mig-product_price_category branch from 7e05e71 to 59bf845 Compare May 21, 2025 14:45

bealdav marked this pull request as ready for review May 22, 2025 07:24

florian-dacosta approved these changes May 22, 2025

View reviewed changes

rousseldenis added needs review migration labels May 22, 2025

OCA-git-bot added this to the 18.0 milestone May 22, 2025

OCA-git-bot mentioned this pull request May 22, 2025

Migration to version 18.0 #3344

Open

rousseldenis reviewed May 22, 2025

View reviewed changes

JordiMForgeFlow reviewed May 22, 2025

View reviewed changes

florian-dacosta force-pushed the 18.0-mig-product_price_category branch from e0a4997 to 355c4e7 Compare May 22, 2025 12:08

etobella force-pushed the 18.0 branch from 4e676b6 to a6df617 Compare October 8, 2025 08:27

grindtildeath and others added 12 commits December 23, 2025 15:32

[add] Module product price category

f1acbb3

[FIX] Module product price category

c7802a4

OCA Transbot updated translations from Transifex

1699c2b

OCA Transbot updated translations from Transifex

56ce33b

[UPD] Update product_price_category.pot [ADD] icon.png

Translated using Weblate (Italian)

3dce1f9

Currently translated at 73.3% (11 of 15 strings) Translation: sale-workflow-10.0/sale-workflow-10.0-product_price_category Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-product_price_category/it/

Translated using Weblate (Catalan)

f8e95bb

Currently translated at 100.0% (15 of 15 strings) Translation: sale-workflow-10.0/sale-workflow-10.0-product_price_category Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-product_price_category/ca/

product_price_category 10.0.1.0.1

731b711

[16.0][MIG] - product_price_category

3a32450

[FIX] - fix ui Co-authored-by: Laurent Mignon (ACSONE) <laurent.mignon@acsone.eu>

[FIX] product_price_category: compute name correctly

872169b

Prior to this commit `name` was not correctly computed when `applied_on` value is `2b_product_price_category`.

[UPD] Update product_price_category.pot

d8dfd65

bealdav and others added 4 commits December 23, 2025 15:32

[IMP] product_price_category: pre-commit execution

d96c122

[MIG] product_price_category: Migration to 18.0

e1cc15c

[FIX] fix tests and add on change for the price category option on pr…

10d68d5

…icelist

product_price_category : Add migration script for v18

812cb68

bealdav force-pushed the 18.0-mig-product_price_category branch from 355c4e7 to 812cb68 Compare December 23, 2025 14:33

IMP prd_price_categ: _compute_name needs depends on price_category_id

3d6aa3e

bealdav force-pushed the 18.0-mig-product_price_category branch from b3753ee to 3d6aa3e Compare January 20, 2026 11:58

florian-dacosta approved these changes Jan 20, 2026

View reviewed changes

sebastienbeau approved these changes Jan 22, 2026

View reviewed changes

OCA-git-bot added the approved label Jan 22, 2026

OCA-git-bot added a commit that referenced this pull request Jan 22, 2026

Merge PR #3618 into 18.0

c84948e

Signed-off-by sebastienbeau

OCA-git-bot added the bot is merging ⏳ label Jan 22, 2026

OCA-git-bot added ready to merge and removed bot is merging ⏳ labels Jan 22, 2026

OCA-git-bot merged commit 0fb6bf4 into OCA:18.0 Jan 22, 2026
9 checks passed

OCA-git-bot added the merged 🎉 label Jan 22, 2026

bealdav deleted the 18.0-mig-product_price_category branch January 22, 2026 13:38

Uh oh!

Conversation

bealdav commented Mar 10, 2025

Uh oh!

bealdav commented May 22, 2025

Uh oh!

florian-dacosta commented May 22, 2025

Uh oh!

rousseldenis commented May 22, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sebastienbeau Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

florian-dacosta left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sebastienbeau left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Jan 22, 2026

Uh oh!

sebastienbeau commented Jan 22, 2026

Uh oh!

OCA-git-bot commented Jan 22, 2026

Uh oh!

OCA-git-bot commented Jan 22, 2026

Uh oh!

OCA-git-bot commented Jan 22, 2026

Uh oh!

Uh oh!

OCA-git-bot commented Jan 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

sebastienbeau Jan 13, 2026 •

edited

Loading

florian-dacosta left a comment •

edited

Loading