[18.0][MIG] sale_tier_validation: Migration to version 18.0#3601
Merged
Conversation
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_tier_validation/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-13.0/sale-workflow-13.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_tier_validation/
Currently translated at 100.0% (13 of 13 strings) Translation: sale-workflow-13.0/sale-workflow-13.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_tier_validation/zh_CN/
Currently translated at 100.0% (13 of 13 strings) Translation: sale-workflow-13.0/sale-workflow-13.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_tier_validation/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-14.0/sale-workflow-14.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_tier_validation/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-15.0/sale-workflow-15.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_tier_validation/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-15.0/sale-workflow-15.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_tier_validation/
Currently translated at 100.0% (19 of 19 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_tier_validation/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_tier_validation/
Currently translated at 100.0% (20 of 20 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_tier_validation/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-17.0/sale-workflow-17.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_tier_validation/
Currently translated at 100.0% (22 of 22 strings) Translation: sale-workflow-17.0/sale-workflow-17.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_tier_validation/es/
Currently translated at 100.0% (22 of 22 strings) Translation: sale-workflow-17.0/sale-workflow-17.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_tier_validation/it/
Currently translated at 100.0% (22 of 22 strings) Translation: sale-workflow-17.0/sale-workflow-17.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_tier_validation/sv/
Member
|
/ocabot migration sale_tier_validation |
StefanRijnhart
approved these changes
Feb 26, 2025
StefanRijnhart
left a comment
Member
There was a problem hiding this comment.
Thanks. You could perhaps refactor the test class to use setUpClass.
Contributor
Author
Sorry, but I don't understand. It already uses
|
f3198aa to
0a8a2c5
Compare
Contributor
Author
|
@StefanRijnhart, I updated the code. Please let me know if it's OK for you, and if these were your comments that I misunderstood initially. |
StefanRijnhart
approved these changes
Feb 26, 2025
StefanRijnhart
left a comment
Member
There was a problem hiding this comment.
You are right, I must have been mixing up PRs! The additional refactoring is great, thanks!
Contributor
|
This PR has the |
Contributor
Author
|
ping @pedrobaeza |
Member
|
/ocabot merge nobump |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
Contributor
|
Congratulations, your PR was merged at 72b2778. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #3417
TT54315
@Tecnativa @pedrobaeza @StefanRijnhart @rousseldenis @acsonefho @Pani-k-folk could you please review this.