[18.0][MIG] sale_validity_auto_cancel: Migration to 18.0#3493
Conversation
9c90dc5 to
f3be133
Compare
… SO functionality by adding new field to contact [17.0][IMP] sale_validity_auto_cancel: Extend the auto cancel expired SO functionality by adding new field to contact [17.0][IMP] sale_validity_auto_cancel: Extend the auto cancel expired SO functionality by adding new field to contact
Currently translated at 100.0% (13 of 13 strings) Translation: sale-workflow-17.0/sale-workflow-17.0-sale_validity_auto_cancel Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_validity_auto_cancel/it/
07a0928 to
dd1373c
Compare
dd1373c to
e3d5e8e
Compare
|
/ocabot migration sale_validity_auto_cancel |
|
FYI: New PR #4022 is based on this PR. |
@anthonissen-a Usually, it is better to do a PR with the change on @BhaveshHeliconia repository than doing a new PR here. |
|
@BhaveshHeliconia Do you mind if we switch to #4022 ? |
Why would I mind? I don’t. If there’s a newer PR that works better and provides an improved approach, I’m happy to switch to that one. |
I commented to go further on this refactoring (i didn't created an other PR, you're will suffice i presum. But if you want me to propose a new one to replace the current one please tell me) |
If there are no major refactors, please suggest the changes here. Otherwise, feel free to create a new PR for the refactoring—I’m fine with either approach. |
Ok. I take it back and I'll propose a new PR for the refactoring then. Thanks |
|
@StephaneMangin @BhaveshHeliconia to me both works as #4128 seems to include all commits of this PR + one commit
But, as this was used by @StephaneMangin we can consider it was used and tested by him and is valid already and has enough review/testing to be merged right now, while #4128 still needs a couple of reviews. |
|
I proceed as 1 after a little chat with @StephaneMangin |
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 4d54a56. Thanks a lot for contributing to OCA. ❤️ |
No description provided.