[18.0] [MIG] sale_order_line_menu: Migration to 18.0 by Borruso · Pull Request #3470 · OCA/sale-workflow

Borruso · 2024-12-07T14:39:48Z

Migration from 17.0 to 18.0

… (Belgium)) Translated using Weblate (French (France)) Currently translated at 100.0% (1 of 1 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_line_menu Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_line_menu/fr_FR/ Added translation using Weblate (Spanish) Translated using Weblate (Spanish) Currently translated at 100.0% (1 of 1 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_line_menu Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_line_menu/es/ Added translation using Weblate (French (Belgium)) Added translation using Weblate (French) Translated using Weblate (French) Currently translated at 100.0% (1 of 1 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_line_menu Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_line_menu/fr/

… sale order lines menu

…if you do not have any Sales permission

@rafaelbn

New views and fields added to the sale_order_line_menu MT-2028 @moduon @rafaelbn @dreispt @Shide @fcvalgar please review

Currently translated at 100.0% (19 of 19 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_line_menu Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_line_menu/es/

Naraka · 2024-12-09T16:06:55Z

If you try to create a new order line within the form of an existing order line, it throws an error.

rousseldenis · 2024-12-10T12:38:25Z

/ocabot migration sale_order_line_menu

sheragar

LGTM. Funtional Review 👍

Borruso · 2024-12-12T14:59:29Z

If you try to create a new order line within the form of an existing order line, it throws an error.

Can you check again?

Naraka

LGTM, tested in runboat

OCA-git-bot · 2024-12-13T11:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Shide

Code LGTM

PieterPaulussen

Thanks for the changes regarding my feedback. There are indeed other issues that need to be addressed in a different PR. But this will suffice for now. THanks.

joepsanders · 2025-01-29T14:00:26Z

@PieterPaulussen is this PR ready for merging? What other issues need to be addressed? Could you point that PR? Thanks!

PieterPaulussen · 2025-01-29T14:02:29Z

@joepsanders The PR has 4 approvals, including mine. I thinks it's safe to merge.

pedrobaeza · 2025-01-29T14:14:05Z

Technically, a PSC should review it, no matter the number of approvals, but I see some respected contributors that have approved already, so merging:

/ocabot merge nobump

OCA-git-bot · 2025-01-29T14:14:13Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-3470-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2025-01-29T14:20:51Z

Congratulations, your PR was merged at 95a65c1. Thanks a lot for contributing to OCA. ❤️

Signed-off-by pedrobaeza

Freni-OSI and others added 16 commits December 7, 2024 15:31

[14.0][ADD]Added Module sale_order_line_menu

80ace7f

[MIG] sale_order_line_menu: Migration to 15.0

4b997a2

[16.0][MIG] sale_order_line_menu

ee0b662

Added translation using Weblate (Croatian)

7092973

[16.0][IMP]sale_order_line_menu: set no visible sections and notes in…

befebf8

… sale order lines menu

[16.0][IMP]sale_order_line_menu: set no visible sale order line menu …

3a178e3

…if you do not have any Sales permission

[16.0][IMP] sale_order_line_menu: New views and stored fields

afca418

New views and fields added to the sale_order_line_menu MT-2028 @moduon @rafaelbn @dreispt @Shide @fcvalgar please review

Translated using Weblate (Spanish)

9dba915

Currently translated at 100.0% (19 of 19 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_line_menu Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_line_menu/es/

Convert sale_order_line_menu readme fragments to markdown

13d9e60

Added translation using Weblate (Portuguese (Brazil))

c263703

Added translation using Weblate (German)

3f8cf9e

Added translation using Weblate (Italian)

3224779

[IMP] sale_order_line_menu: black, isort, prettier

b7e0137

[MIG] sale_order_line_menu: Migration to 17.0

befcf5c

[IMP] sale_order_line_menu: pre-commit auto fixes

8ff0579

Borruso force-pushed the 18.0-mig-sale_order_line_menu branch 2 times, most recently from 51a7f4c to 414a138 Compare December 7, 2024 15:20

rousseldenis added needs review migration labels Dec 10, 2024

OCA-git-bot added this to the 18.0 milestone Dec 10, 2024

OCA-git-bot mentioned this pull request Dec 10, 2024

Migration to version 18.0 #3344

Open

sheragar approved these changes Dec 11, 2024

View reviewed changes

Borruso force-pushed the 18.0-mig-sale_order_line_menu branch 2 times, most recently from 77878fb to 96bf699 Compare December 12, 2024 14:32

Naraka approved these changes Dec 13, 2024

View reviewed changes

OCA-git-bot added the approved label Dec 13, 2024

OCA-git-bot added the ready to merge label Dec 13, 2024

Shide approved these changes Dec 18, 2024

View reviewed changes

PieterPaulussen suggested changes Jan 7, 2025

View reviewed changes

OCA-git-bot removed approved ready to merge labels Jan 7, 2025

Shide approved these changes Jan 9, 2025

View reviewed changes

Borruso force-pushed the 18.0-mig-sale_order_line_menu branch from 96bf699 to 7f8fa7a Compare January 10, 2025 09:35

Borruso requested a review from PieterPaulussen January 10, 2025 09:35

Borruso force-pushed the 18.0-mig-sale_order_line_menu branch 3 times, most recently from c8a0606 to fdbf560 Compare January 13, 2025 08:54

[MIG] sale_order_line_menu: Migration to 18.0

c7bde69

Borruso force-pushed the 18.0-mig-sale_order_line_menu branch from fdbf560 to c7bde69 Compare January 13, 2025 09:01

PieterPaulussen approved these changes Jan 13, 2025

View reviewed changes

OCA-git-bot added the approved label Jan 13, 2025

OCA-git-bot added the bot is merging ⏳ label Jan 29, 2025

OCA-git-bot merged commit 75da61d into OCA:18.0 Jan 29, 2025

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jan 29, 2025

trisdoan pushed a commit to trisdoan/sale-workflow that referenced this pull request Mar 13, 2025

Merge PR OCA#3470 into 18.0

9e21d59

Signed-off-by pedrobaeza

Uh oh!

Conversation

Borruso commented Dec 7, 2024

Uh oh!

Naraka commented Dec 9, 2024

Uh oh!

rousseldenis commented Dec 10, 2024

Uh oh!

sheragar left a comment

Choose a reason for hiding this comment

Uh oh!

Borruso commented Dec 12, 2024

Uh oh!

Naraka left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Dec 13, 2024

Uh oh!

Shide left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PieterPaulussen left a comment

Choose a reason for hiding this comment

Uh oh!

joepsanders commented Jan 29, 2025

Uh oh!

PieterPaulussen commented Jan 29, 2025

Uh oh!

pedrobaeza commented Jan 29, 2025

Uh oh!

OCA-git-bot commented Jan 29, 2025

Uh oh!

OCA-git-bot commented Jan 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants