Skip to content

Auto argument ordering#1042

Merged
megawac merged 6 commits into
masterfrom
auto-argument-ordering
Mar 1, 2016
Merged

Auto argument ordering#1042
megawac merged 6 commits into
masterfrom
auto-argument-ordering

Conversation

@aearly

@aearly aearly commented Feb 28, 2016

Copy link
Copy Markdown
Collaborator

Closes #1036 and resolves #1023

Makes auto tasks work like standard async functions -- the callback is always the last arg.

megawac added a commit that referenced this pull request Mar 1, 2016
@megawac megawac merged commit 1b2afb5 into master Mar 1, 2016
@megawac

megawac commented Mar 1, 2016

Copy link
Copy Markdown
Collaborator

Lets get the some/every error callback stuff in and then do a prerelease @aearly

@megawac megawac deleted the auto-argument-ordering branch March 1, 2016 00:21
@aearly

aearly commented Mar 5, 2016

Copy link
Copy Markdown
Collaborator Author

I'd wait until we have all the scheduled breaking changes in. Then early adopters only have to audit their code once for 2.0.

@aearly aearly added this to the 2.0 milestone Mar 5, 2016
@PanMan

PanMan commented Mar 22, 2016

Copy link
Copy Markdown

It really confused me that this is on the main readme, while my code (on 1.x) doesn't handle this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix callback argument order in async.auto async.auto: should subsequent tasks still run if the chain as a whole has been marked as failed?

3 participants